netdev - Re: [PATCH net-next v5 02/13] net: wwan: t7xx: Add control DMA interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d83e8fa4-a22f-6e3f-ec9d-16e798904efe@linux.intel.com>
Date:   Mon, 7 Mar 2022 16:46:06 -0800
From:   "Martinez, Ricardo" <ricardo.martinez@...ux.intel.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     Netdev <netdev@...r.kernel.org>, linux-wireless@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net, johannes@...solutions.net,
        ryazanov.s.a@...il.com, loic.poulain@...aro.org,
        m.chetan.kumar@...el.com, chandrashekar.devegowda@...el.com,
        linuxwwan@...el.com, chiranjeevi.rapolu@...ux.intel.com,
        haijun.liu@...iatek.com, amir.hanania@...el.com,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        dinesh.sharma@...el.com, eliot.lee@...el.com,
        moises.veleta@...el.com, pierre-louis.bossart@...el.com,
        muralidharan.sethuraman@...el.com, Soumya.Prakash.Mishra@...el.com,
        sreehari.kancharla@...el.com, madhusmita.sahu@...el.com
Subject: Re: [PATCH net-next v5 02/13] net: wwan: t7xx: Add control DMA
 interface


On 2/25/2022 2:54 AM, Ilpo Järvinen wrote:
> On Wed, 23 Feb 2022, Ricardo Martinez wrote:
...
>> +/**
>> + * t7xx_cldma_send_skb() - Send control data to modem.
>> + * @md_ctrl: CLDMA context structure.
>> + * @qno: Queue number.
>> + * @skb: Socket buffer.
>> + *
>> + * Return:
> ...
>> + * * -EBUSY	- Resource lock failure.
> Leftover?

This function can still return -EBUSY if 
t7xx_pci_sleep_disable_complete() fails.

Maybe returning -ETIMED would make more sense based on the 
implementation of t7xx_pci_sleep_disable_complete().

>
> ...with those addressed
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
>
>
> And kudos for rx_not_done -> pending_rx_int change. It was a minor
> thing for me but the logic is so much easier to understand now with
> that better name :-).
>
> Some other nice cleanups compared with v4 also noted.
>
>