lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Mar 2022 16:47:05 -0800 From: "Martinez, Ricardo" <ricardo.martinez@...ux.intel.com> To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com> Cc: Netdev <netdev@...r.kernel.org>, linux-wireless@...r.kernel.org, kuba@...nel.org, davem@...emloft.net, johannes@...solutions.net, ryazanov.s.a@...il.com, loic.poulain@...aro.org, m.chetan.kumar@...el.com, chandrashekar.devegowda@...el.com, linuxwwan@...el.com, chiranjeevi.rapolu@...ux.intel.com, haijun.liu@...iatek.com, amir.hanania@...el.com, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, dinesh.sharma@...el.com, eliot.lee@...el.com, moises.veleta@...el.com, pierre-louis.bossart@...el.com, muralidharan.sethuraman@...el.com, Soumya.Prakash.Mishra@...el.com, sreehari.kancharla@...el.com, madhusmita.sahu@...el.com Subject: Re: [PATCH net-next v5 03/13] net: wwan: t7xx: Add core components On 2/25/2022 3:10 AM, Ilpo Järvinen wrote: > On Wed, 23 Feb 2022, Ricardo Martinez wrote: > >> From: Haijun Liu <haijun.liu@...iatek.com> >> >> Registers the t7xx device driver with the kernel. Setup all the core >> components: PCIe layer, Modem Host Cross Core Interface (MHCCIF), >> modem control operations, modem state machine, and build >> infrastructure. >> >> * PCIe layer code implements driver probe and removal. >> * MHCCIF provides interrupt channels to communicate events >> such as handshake, PM and port enumeration. >> * Modem control implements the entry point for modem init, >> reset and exit. >> * The modem status monitor is a state machine used by modem control >> to complete initialization and stop. It is used also to propagate >> exception events reported by other components. >> >> Signed-off-by: Haijun Liu <haijun.liu@...iatek.com> >> Signed-off-by: Chandrashekar Devegowda <chandrashekar.devegowda@...el.com> >> Co-developed-by: Ricardo Martinez <ricardo.martinez@...ux.intel.com> >> Signed-off-by: Ricardo Martinez <ricardo.martinez@...ux.intel.com> >> >> >From a WWAN framework perspective: >> Reviewed-by: Loic Poulain <loic.poulain@...aro.org> >> --- >> + /* IPs enable interrupts when ready */ >> + for (i = 0; i < EXT_INT_NUM; i++) >> + t7xx_pcie_mac_clear_int(t7xx_dev, i); > In v4, PCIE_MAC_MSIX_MSK_SET() wrote to IMASK_HOST_MSIX_SET_GRP0_0. > In v5, t7xx_pcie_mac_clear_int() writes to IMASK_HOST_MSIX_CLR_GRP0_0. > > t7xx_pcie_mac_set_int() would write to IMASK_HOST_MSIX_SET_GRP0_0 > matching to what v4 did. So you probably want to call > t7xx_pcie_mac_set_int() instead of t7xx_pcie_mac_clear_int()? Yes, this should call t7xx_pcie_mac_set_int(). >
Powered by blists - more mailing lists