netdev - Re: [PATCH net] net: dsa: silence fdb errors when unsupported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220309104143.gmoks5aceq3dtmci@skbuf>
Date:   Wed, 9 Mar 2022 12:41:43 +0200
From:   Vladimir Oltean <olteanv@...il.com>
To:     "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net] net: dsa: silence fdb errors when unsupported

Hello Russell,

On Wed, Mar 09, 2022 at 10:35:32AM +0000, Russell King (Oracle) wrote:
> When booting with a Marvell 88e6xxx switch, the kernel spits out a
> load of:
> 
> [    7.820996] mv88e6085 f1072004.mdio-mii:04: port 3 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> [    7.835717] mv88e6085 f1072004.mdio-mii:04: port 2 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> [    7.851090] mv88e6085 f1072004.mdio-mii:04: port 1 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> [    7.968594] mv88e6085 f1072004.mdio-mii:04: port 0 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> [    8.035408] mv88e6085 f1072004.mdio-mii:04: port 3 failed to add aa:bb:cc:dd:ee:ff vid XYZ3 to fdb: -95
> 
> while the switch is being setup. Comments in the Marvell DSA driver
> indicate that "switchdev expects -EOPNOTSUPP to honor software VLANs"
> in mv88e6xxx_port_db_load_purge() so this error code should not be
> treated as an error.
> 
> Fixes: 3dc80afc5098 ("net: dsa: introduce a separate cross-chip notifier type for host FDBs")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
> Hi,
> 
> I noticed these errors booting 5.16 on my Clearfog platforms with a
> Marvell DSA switch. It appears that the switch continues to work
> even though these errors are logged in the kernel log, so this patch
> merely silences the errors, but I'm unsure this is the right thing
> to do.

Can you please confirm that these errors have disappeared on net-next?

> 
>  net/dsa/slave.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 22241afcac81..e8f4a59022a8 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -2411,7 +2411,7 @@ static void dsa_slave_switchdev_event_work(struct work_struct *work)
>  		else
>  			err = dsa_port_fdb_add(dp, switchdev_work->addr,
>  					       switchdev_work->vid);
> -		if (err) {
> +		if (err && err != -EOPNOTSUPP) {
>  			dev_err(ds->dev,
>  				"port %d failed to add %pM vid %d to fdb: %d\n",
>  				dp->index, switchdev_work->addr,
> @@ -2428,7 +2428,7 @@ static void dsa_slave_switchdev_event_work(struct work_struct *work)
>  		else
>  			err = dsa_port_fdb_del(dp, switchdev_work->addr,
>  					       switchdev_work->vid);
> -		if (err) {
> +		if (err && err != -EOPNOTSUPP) {
>  			dev_err(ds->dev,
>  				"port %d failed to delete %pM vid %d from fdb: %d\n",
>  				dp->index, switchdev_work->addr,
> -- 
> 2.30.2
>