netdev - Re: [PATCH net] net: dsa: silence fdb errors when unsupported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yii3SH7/mF7QmXO1@shell.armlinux.org.uk>
Date:   Wed, 9 Mar 2022 14:18:48 +0000
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Heiner Kallweit <hkallweit1@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net] net: dsa: silence fdb errors when unsupported

On Wed, Mar 09, 2022 at 12:41:43PM +0200, Vladimir Oltean wrote:
> Hello Russell,
> 
> On Wed, Mar 09, 2022 at 10:35:32AM +0000, Russell King (Oracle) wrote:
> > When booting with a Marvell 88e6xxx switch, the kernel spits out a
> > load of:
> > 
> > [    7.820996] mv88e6085 f1072004.mdio-mii:04: port 3 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> > [    7.835717] mv88e6085 f1072004.mdio-mii:04: port 2 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> > [    7.851090] mv88e6085 f1072004.mdio-mii:04: port 1 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> > [    7.968594] mv88e6085 f1072004.mdio-mii:04: port 0 failed to add aa:bb:cc:dd:ee:ff vid XYZ1 to fdb: -95
> > [    8.035408] mv88e6085 f1072004.mdio-mii:04: port 3 failed to add aa:bb:cc:dd:ee:ff vid XYZ3 to fdb: -95
> > 
> > while the switch is being setup. Comments in the Marvell DSA driver
> > indicate that "switchdev expects -EOPNOTSUPP to honor software VLANs"
> > in mv88e6xxx_port_db_load_purge() so this error code should not be
> > treated as an error.
> > 
> > Fixes: 3dc80afc5098 ("net: dsa: introduce a separate cross-chip notifier type for host FDBs")
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> > ---
> > Hi,
> > 
> > I noticed these errors booting 5.16 on my Clearfog platforms with a
> > Marvell DSA switch. It appears that the switch continues to work
> > even though these errors are logged in the kernel log, so this patch
> > merely silences the errors, but I'm unsure this is the right thing
> > to do.
> 
> Can you please confirm that these errors have disappeared on net-next?

net-next: no warnings
v5.17-rc7: warnings
v5.16: warnings

So, it looks like we need a patch for 5.17-rc7 and 5.16-stable to fix
this. Do you have a better suggestion than my patch?

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!