netdev - Re: [PATCH] alx: acquire mutex for alx_reinit in alx_change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220310152040.0389f6c1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 10 Mar 2022 15:20:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Niels Dossche <dossche.niels@...il.com>
Cc:     netdev@...r.kernel.org, Chris Snook <chris.snook@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH] alx: acquire mutex for alx_reinit in alx_change_mtu

On Fri, 11 Mar 2022 00:14:55 +0100 Niels Dossche wrote:
> On 11/03/2022 00:05, Jakub Kicinski wrote:
> > On Thu, 10 Mar 2022 17:13:16 +0100 Niels Dossche wrote:  
> >> alx_reinit has a lockdep assertion that the alx->mtx mutex must be held.
> >> alx_reinit is called from two places: alx_reset and alx_change_mtu.
> >> alx_reset does acquire alx->mtx before calling alx_reinit.
> >> alx_change_mtu does not acquire this mutex, nor do its callers or any
> >> path towards alx_change_mtu.
> >> Acquire the mutex in alx_change_mtu.
> >>
> >> Signed-off-by: Niels Dossche <dossche.niels@...il.com>  
> > 
> > What's the Fixes tag?  
> 
> Commit 4a5fe57e7751 ("alx: use fine-grained locking instead of RTNL")
> introduced fine-grained locking and introduced the assertion.
> I can resend the patch with the Fixes tag if you want me to.

If you don't mind resend would be helpful, thanks!