netdev - Re: [PATCH net-next 2/2] ice: Add inline flow director support for channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220311124909.7112318a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 11 Mar 2022 12:49:09 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
Cc:     Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
        Kiran Patil <kiran.patil@...el.com>, <netdev@...r.kernel.org>,
        <sudheer.mogilappagari@...el.com>, <amritha.nambiar@...el.com>,
        <jiri@...dia.com>, <leonro@...dia.com>,
        Bharathi Sreenivas <bharathi.sreenivas@...el.com>
Subject: Re: [PATCH net-next 2/2] ice: Add inline flow director support for
 channels

On Fri, 11 Mar 2022 12:36:55 -0600 Samudrala, Sridhar wrote:
> > Why is this in devlink and not ethtool?  
> 
> This is 16bit value with each bit representing a TC and is used to
> enable/disable inline flow director per queue group or TC.
> tc mqprio command allows creating upto 16 TCs.
> 
> My understanding is that ethtool parameters are per netedev or per-queue,
> but we don't have good way to configure per-queue_group parameters
> via ethtool. So we went with devlink.

ethtool has RSS context which is what you should use.
I presume you used TCs because it's a quick shortcut for getting
rate control?

> > All devlink params must be clearly documented.  
> 
> Based on the discussion in the other thread, we will make this a
> devlink parameter that is registered at probe time
>     https://lore.kernel.org/netdev/Yit3sLq6b+ZNZ07j@unreal/
> Will add documentation in the next revision.
> Hope this is OK.

It is not. Please tell everyone at intel that ramming features
thru devlink params is not welcome. You would know that if you
read the mailing list but I guess that's asking too much :/