netdev - Re: [PATCH net-next 2/2] ice: Add inline flow director support for channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Mar 2022 17:11:42 -0500
From:   "Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
        <netdev@...r.kernel.org>, <sudheer.mogilappagari@...el.com>,
        <amritha.nambiar@...el.com>, <jiri@...dia.com>,
        <leonro@...dia.com>,
        "Bharathi Sreenivas" <bharathi.sreenivas@...el.com>
Subject: Re: [PATCH net-next 2/2] ice: Add inline flow director support for
 channels

On 3/11/2022 2:49 PM, Jakub Kicinski wrote:
> On Fri, 11 Mar 2022 12:36:55 -0600 Samudrala, Sridhar wrote:
>>> Why is this in devlink and not ethtool?
>> This is 16bit value with each bit representing a TC and is used to
>> enable/disable inline flow director per queue group or TC.
>> tc mqprio command allows creating upto 16 TCs.
>>
>> My understanding is that ethtool parameters are per netedev or per-queue,
>> but we don't have good way to configure per-queue_group parameters
>> via ethtool. So we went with devlink.
> ethtool has RSS context which is what you should use.
> I presume you used TCs because it's a quick shortcut for getting
> rate control?
>
When tc mqprio hw offload is used to split tx/rx queues into queue groups, we
create rss contexts per queue group automatically.
Today we are not exposing the rss indirection table for queue groups via ethtool.
We will add that support by enabling get_rxfh_context() ethtool_ops.

IIUC, you are suggesting using the rsvd fields in struct ethtool_rxfh to enable
additional per-rss_context parameters.

ethtool -X enp175s0f0 context 1 inline_fd on/off

Will this be acceptable?

Thanks
Sridhar