netdev - Re: [RFT net-next 0/6] devlink: expose instance locking and simplify port splitting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220315085829.51d2fd5c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 15 Mar 2022 08:58:29 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leonro@...dia.com>
Cc:     Ido Schimmel <idosch@...sch.org>, <idosch@...dia.com>,
        <petrm@...dia.com>, <simon.horman@...igine.com>,
        <netdev@...r.kernel.org>, <jiri@...nulli.us>,
        Michael Chan <michael.chan@...adcom.com>
Subject: Re: [RFT net-next 0/6] devlink: expose instance locking and
 simplify port splitting

On Tue, 15 Mar 2022 09:39:31 +0200 Leon Romanovsky wrote:
> > I have the eswitch mode conversion patches almost ready with the
> > "almost" being mlx5.   
> 
> I wonder why do you need to change eswitch locking in mlx5?

I want DEVLINK_CMD_ESWITCH_SET to drop the DEVLINK_NL_FLAG_NO_LOCK
marking.

Other drivers are rather simple in terms of locking (bnxt, nfp,
netdevsim) and I can replace driver locking completely with a few 
minor changes. Other drivers have no locking (insert cry/laugh emoji).

mlx5 has layers and multiple locks, if you're okay with devl_unlock() /
devl_lock() inside the callback that's perfect for me.