netdev - Re: [PATCH] net: axiemac: initialize PHY before device reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1be44aa629465d0cb70ec26828bf70f83d55f98f.camel@calian.com>
Date:   Wed, 16 Mar 2022 20:55:32 +0000
From:   Robert Hancock <robert.hancock@...ian.com>
To:     "andy.chiu@...ive.com" <andy.chiu@...ive.com>
CC:     "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "greentime.hu@...ive.com" <greentime.hu@...ive.com>
Subject: Re: [PATCH] net: axiemac: initialize PHY before device reset

Re: https://lore.kernel.org/all/20220316075707.61321-1-andy.chiu@sifive.com/
(looks like I was CCed with the wrong email address):

I'm not sure about this patch. It seems odd/possibly unsafe to reset the whole
core (including the MDIO interface) after connecting the PHY which communicates
over MDIO, so it's not obvious to me that this is more correct than the
original order?

-- 
Robert Hancock
Senior Hardware Designer, Calian Advanced Technologies
www.calian.com