netdev - Re: [net-next] can: isotp: sanitize CAN ID checks in isotp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7445f2f1-4d89-116e-0cf7-fc7338c2901f@hartkopp.net>
Date:   Wed, 16 Mar 2022 08:53:54 +0100
From:   Oliver Hartkopp <socketcan@...tkopp.net>
To:     Marc Kleine-Budde <mkl@...gutronix.de>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        syzbot+2339c27f5c66c652843e@...kaller.appspotmail.com
Subject: Re: [net-next] can: isotp: sanitize CAN ID checks in isotp_bind()



On 16.03.22 08:48, Marc Kleine-Budde wrote:
> On 16.03.2022 08:35:58, Oliver Hartkopp wrote:
>>
>>
>> On 16.03.22 02:51, Jakub Kicinski wrote:
>>> On Tue, 15 Mar 2022 21:37:48 +0100 Oliver Hartkopp wrote:
>>>> Syzbot created an environment that lead to a state machine status that
>>>> can not be reached with a compliant CAN ID address configuration.
>>>> The provided address information consisted of CAN ID 0x6000001 and 0xC28001
>>>> which both boil down to 11 bit CAN IDs 0x001 in sending and receiving.
>>>>
>>>> Sanitize the SFF/EFF CAN ID values before performing the address checks.
>>>>
>>>> Fixes: e057dd3fc20f ("can: add ISO 15765-2:2016 transport protocol")
>>>> Reported-by: syzbot+2339c27f5c66c652843e@...kaller.appspotmail.com
>>>> Signed-off-by: Oliver Hartkopp <socketcan@...tkopp.net>
>>>
>>> CC Marc, please make sure you CC maintainers.
>>
>> Oh, that would have been better! I'm maintaining the CAN network layer stuff
>> together with Marc and there was no relevant stuff in can-next to be pulled
>> in the next days. So I sent it directly to hit the merge window and had all
>> of us in the reply to the syzbot report.
>>
>> Will CC Marc next time when posting to netdev only!
>>
>> Maybe I treated this patch more urgent than it needed to be handled
>> ¯\_(ツ)_/¯
> 
> Should this go into net/master with stable on Cc or to net-next?

This patch is for net-next as it won't apply to net/master nor the 
stable trees due to the recent changes in net-next.

As it contains a Fixes: tag I would send the patch for the stable trees 
when the patch hits Linus' tree and likely Greg would show up asking for it.

I hope that's the most elegant process here?!?

Best regards,
Oliver