netdev - Re: [PATCH] iwlwifi: mei: fix building iwlmei

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3554c5cb403df472eca607e036a1f48a7699d490.camel@intel.com>
Date:   Thu, 17 Mar 2022 11:06:58 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "Grumbach, Emmanuel" <emmanuel.grumbach@...el.com>,
        "arnd@...nel.org" <arnd@...nel.org>
CC:     "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "Beker, Ayala" <ayala.beker@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] iwlwifi: mei: fix building iwlmei

On Wed, 2022-03-16 at 18:55 +0000, Grumbach, Emmanuel wrote:
> > 
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > Building iwlmei without CONFIG_CFG80211 causes a link-time warning:
> > 
> > ld.lld: error: undefined symbol: ieee80211_hdrlen
> > > > > referenced by net.c
> > > > > 
> > > > > net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme
> > > > > ) in
> > > > > archive drivers/built-in.a
> > 
> > Add an explicit dependency to avoid this. In theory it should not
> > be needed
> > here, but it also seems pointless to allow IWLMEI for
> > configurations without
> > CFG80211.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > ---
> >  drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > I see this warning on 5.17-rc8, but did not test it on linux-next,
> > which may
> > already have a fix.
> > 
> > diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig
> > b/drivers/net/wireless/intel/iwlwifi/Kconfig
> > index 85e704283755..a647a406b87b 100644
> > --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> > +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> > @@ -139,6 +139,7 @@ config IWLMEI
> >  	tristate "Intel Management Engine communication over WLAN"
> >  	depends on INTEL_MEI
> >  	depends on PM
> > +	depends on CFG80211
> >  	help
> >  	  Enables the iwlmei kernel module.
> > 
> 
> FWIW: Luca just merged the exact same patch internally. So
> Acked-by: Emmanuel Grumbach <Emmanuel.grumbach@...el.com>

Yeah, please take this.

Acked-by: Luca Coelho <luciano.coelho@...el.com>

--
Cheers,
Luca.