netdev - RE: [PATCH iproute2-next v5 1/2] ip: GTP support in ip link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW4PR11MB57765F252A537045612889E4FD129@MW4PR11MB5776.namprd11.prod.outlook.com>
Date:   Thu, 17 Mar 2022 11:11:40 +0000
From:   "Drewek, Wojciech" <wojciech.drewek@...el.com>
To:     David Ahern <dsahern@...il.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "stephen@...workplumber.org" <stephen@...workplumber.org>,
        Harald Welte <laforge@...monks.org>
Subject: RE: [PATCH iproute2-next v5 1/2] ip: GTP support in ip link

Hi David,

> -----Original Message-----
> From: David Ahern <dsahern@...il.com>
> Sent: czwartek, 17 marca 2022 01:57
> To: Drewek, Wojciech <wojciech.drewek@...el.com>; netdev@...r.kernel.org
> Cc: stephen@...workplumber.org
> Subject: Re: [PATCH iproute2-next v5 1/2] ip: GTP support in ip link
> 
> On 3/16/22 5:08 AM, Wojciech Drewek wrote:
> > +static void gtp_print_opt(struct link_util *lu, FILE *f, struct rtattr *tb[])
> > +{
> > +
> > +	if (tb[IFLA_GTP_ROLE]) {
> > +		__u32 role = rta_getattr_u32(tb[IFLA_GTP_ROLE]);
> > +
> > +		print_string(PRINT_ANY, "role", "role %s ",
> > +			     role == GTP_ROLE_SGSN ? "sgsn" : "ggsn");
> > +	}
> 
> as a u32 does that mean more roles might get added? Seems like this
> should have a attr to string converter that handles future additions.

I think no more roles are expected but we can ask Harald.
Of course I can still implement the converter just in case.

Regards,
Wojtek