netdev - Re: [PATCH bpf-next 0/3] Make 2-byte access to bpf_sk_lookup->remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220318012351.fc52oconw6juljod@kafai-mbp.dhcp.thefacebook.com>
Date:   Thu, 17 Mar 2022 18:23:51 -0700
From:   Martin KaFai Lau <kafai@...com>
To:     Jakub Sitnicki <jakub@...udflare.com>
Cc:     bpf@...r.kernel.org, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        kernel-team@...udflare.com, Ilya Leoshkevich <iii@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>
Subject: Re: [PATCH bpf-next 0/3] Make 2-byte access to
 bpf_sk_lookup->remote_port endian-agnostic

On Thu, Mar 17, 2022 at 05:58:23PM +0100, Jakub Sitnicki wrote:
> This patch set is a result of a discussion we had around the RFC patchset from
> Ilya [1]. The fix for the narrow loads from the RFC series is still relevant,
> but this series does not depend on it. Nor is it required to unbreak sk_lookup
> tests on BE, if this series gets applied.
> 
> To summarize the takeaways from [1]:
> 
>  1) we want to make 2-byte load from ctx->remote_port portable across LE and BE,
>  2) we keep the 4-byte load from ctx->remote_port as it is today - result varies
>     on endianess of the platform.
> 
> [1] https://lore.kernel.org/bpf/20220222182559.2865596-2-iii@linux.ibm.com/
For the set,

Acked-by: Martin KaFai Lau <kafai@...com>