lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 20 Mar 2022 09:53:02 +0800
From:   Xiaomeng Tong <>
Subject: Re: [PATCH] cw1200: remove an unneeded NULL check on list iterator

On Sun, 20 Mar 2022 01:47:26 +0100, Jakob Koschel
<> wrote:  
> I don't think this is fixing anything here. You are basically just removing
> a check that was always true.


> I'm pretty sure that this check is here to check if either the list is empty or no
> element was found. If I'm not wrong, some time ago, lists where not circular but
> actually pointed to NULL (or the head was NULL) so this check made sense but doesn't
> anymore.
> The appropriate fix would be only setting 'item' when a break is hit and keep
> the original check.

You are right if that is the author's original intention. I will fix it in PATCH v2.

> > 			unsigned long tmo = item->queue_timestamp + queue->ttl;
> > 			mod_timer(&queue->gc, tmo);
> > 			cw1200_pm_stay_awake(&stats->priv->pm_state,
> > -- 
> > 2.17.1
> > 
> > 
> I've made those changes already and I'm in the process of upstreaming them in an organized
> way, so maybe it would make sense to synchronize, so we don't post duplicate patches.

Ok, I will cc you when sending related patches to avoid duplication.
I hope you can do the same, thank you.

Here are the 9 patches I have sent, so you don't have to reinvent th wheel:

Xiaomeng Tong

Powered by blists - more mailing lists