netdev - Re: [PATCH v9 net-next 01/11] dt-bindings: net: make internal-delay-ps based on phy-mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1647742413.985820.2990522.nullmailer@robh.at.kernel.org>
Date:   Sat, 19 Mar 2022 20:13:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
Cc:     hkallweit1@...il.com, f.fainelli@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org, kuba@...nel.org,
        UNGLinuxDriver@...rochip.com, linux-kernel@...r.kernel.org,
        davem@...emloft.net, devicetree@...r.kernel.org, andrew@...n.ch,
        olteanv@...il.com, vivien.didelot@...il.com, robh+dt@...nel.org,
        woojung.huh@...rochip.com
Subject: Re: [PATCH v9 net-next 01/11] dt-bindings: net: make internal-delay-ps based on phy-mode

On Fri, 18 Mar 2022 14:25:30 +0530, Prasanna Vengateshan wrote:
> *-internal-delay-ps properties would be applicable only for RGMII interface
> modes.
> 
> It is changed as per the request,
> https://lore.kernel.org/netdev/d8e5f6a8-a7e1-dabd-f4b4-ea8ea21d0a1d@gmail.com/
> 
> Ran dt_binding_check to confirm nothing is broken and submitting as a RFC
> patch to receive feedback.
> 
> Signed-off-by: Prasanna Vengateshan <prasanna.vengateshan@...rochip.com>
> ---
>  .../bindings/net/ethernet-controller.yaml     | 37 +++++++++++++------
>  1 file changed, 25 insertions(+), 12 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/net/ethernet-controller.yaml:232:20: [warning] wrong indentation: expected 18 but found 19 (indentation)
./Documentation/devicetree/bindings/net/ethernet-controller.yaml:233:21: [warning] wrong indentation: expected 21 but found 20 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/patch/1606943

This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit.