netdev - Re: [PATCH net-next] tcp: make tcp_rcv_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1342885-3aed-9c34-8f6a-aa681369ad27@163.com>
Date:   Thu, 24 Mar 2022 10:33:48 +0800
From:   Jianguo Wu <wujianguo106@....com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     David Ahern <dsahern@...nel.org>, Jakub Kicinski <kuba@...nel.org>,
        Menglong Dong <menglong8.dong@...il.com>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] tcp: make tcp_rcv_state_process() drop monitor
 friendly

Hi,
    Thanks for your reply. This is more complicated than I thought, i will do some more dig.

在 2022/3/23 21:40, Eric Dumazet 写道:
> On Wed, Mar 23, 2022 at 6:05 AM Jianguo Wu <wujianguo106@....com> wrote:
>>
>> From: Jianguo Wu <wujianguo@...natelecom.cn>
>>
>> In tcp_rcv_state_process(), should not call tcp_drop() for same case,
>> like after process ACK packet in TCP_LAST_ACK state, it should call
>> consume_skb() instead of tcp_drop() to be drop monitor friendly,
>> otherwise every last ack will be report as dropped packet by drop monitor.
>>
>> Signed-off-by: Jianguo Wu <wujianguo@...natelecom.cn>
>> ---
> 
> 1) net-next is closed
> 
> 2) Same remarks as for the other patch.
>    You mark the packet as consumed, while maybe we had to throw away
> some payload from it ?
> 
> You will have to wait for net-next being open,
> then send patches with one change at a time, with clear explanations
> and possibly packetdrill tests.
> 
> I am concerned about all these patches making future backports
> difficult because of merge conflicts.