lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 23 Mar 2022 06:40:51 -0700
From:   Eric Dumazet <>
To:     Jianguo Wu <>
Cc:     David Ahern <>, Jakub Kicinski <>,
        Menglong Dong <>,
        netdev <>,
        LKML <>
Subject: Re: [PATCH net-next] tcp: make tcp_rcv_state_process() drop monitor friendly

On Wed, Mar 23, 2022 at 6:05 AM Jianguo Wu <> wrote:
> From: Jianguo Wu <>
> In tcp_rcv_state_process(), should not call tcp_drop() for same case,
> like after process ACK packet in TCP_LAST_ACK state, it should call
> consume_skb() instead of tcp_drop() to be drop monitor friendly,
> otherwise every last ack will be report as dropped packet by drop monitor.
> Signed-off-by: Jianguo Wu <>
> ---

1) net-next is closed

2) Same remarks as for the other patch.
   You mark the packet as consumed, while maybe we had to throw away
some payload from it ?

You will have to wait for net-next being open,
then send patches with one change at a time, with clear explanations
and possibly packetdrill tests.

I am concerned about all these patches making future backports
difficult because of merge conflicts.

Powered by blists - more mailing lists