netdev - Re: [PATCH net-next v1 1/6] ptp: Add cycles support for virtual clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANr-f5wsX+eDH+YSc-AxehNnB90gPaTRvwC8NeTae_pUXPAC6Q@mail.gmail.com>
Date:   Thu, 24 Mar 2022 20:39:10 +0100
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     yangbo.lu@....com, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, mlichvar@...hat.com,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v1 1/6] ptp: Add cycles support for virtual clocks

> > diff --git a/drivers/ptp/ptp_private.h b/drivers/ptp/ptp_private.h
> > index dba6be477067..ae66376def84 100644
> > --- a/drivers/ptp/ptp_private.h
> > +++ b/drivers/ptp/ptp_private.h
> > @@ -52,6 +52,7 @@ struct ptp_clock {
> >       int *vclock_index;
> >       struct mutex n_vclocks_mux; /* protect concurrent n_vclocks access */
> >       bool is_virtual_clock;
> > +     bool cycles;
>
> Can we please have something more descriptive?
>
> How about a predicate like is_xyz or has_xyz or xyz_available ?

I'll improve that.

Thanks, Gerhard