netdev - Re: [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANr-f5wrm7ASB61-rR9VPF5ePYC4gb4W-1rM5Ym7TixwMQv_Jw@mail.gmail.com>
Date:   Thu, 24 Mar 2022 20:43:44 +0100
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Richard Cochran <richardcochran@...il.com>
Cc:     yangbo.lu@....com, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, mlichvar@...hat.com,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next v1 2/6] ptp: Request cycles for TX timestamp

> > @@ -683,9 +683,17 @@ void __sock_tx_timestamp(__u16 tsflags, __u8 *tx_flags)
> >  {
> >       u8 flags = *tx_flags;
> >
> > -     if (tsflags & SOF_TIMESTAMPING_TX_HARDWARE)
> > +     if (tsflags & SOF_TIMESTAMPING_TX_HARDWARE) {
> >               flags |= SKBTX_HW_TSTAMP;
> >
> > +             /* PTP hardware clocks can provide a free running time called
> > +              * cycles as base for virtual clocks.
>
> "PTP hardware clocks can provide a free running cycle counter as a
> time base for virtual clocks."

I'll use your wording here. I'll also update other comments and commit messages
with this wording.

Thanks,
Gerhard