netdev - Re: [RFCv5 PATCH net-next 01/20] net: rename net_device->features to net_device->active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220324183549.10ba1260@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 24 Mar 2022 18:35:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "shenjian (K)" <shenjian15@...wei.com>
Cc:     <davem@...emloft.net>, <andrew@...n.ch>, <ecree.xilinx@...il.com>,
        <hkallweit1@...il.com>, <alexandr.lobakin@...el.com>,
        <saeed@...nel.org>, <leon@...nel.org>, <netdev@...r.kernel.org>,
        <linuxarm@...neuler.org>, <lipeng321@...wei.com>
Subject: Re: [RFCv5 PATCH net-next 01/20] net: rename net_device->features
 to net_device->active_features

On Fri, 25 Mar 2022 09:29:51 +0800 shenjian (K) wrote:
> 在 2022/3/25 9:03, Jakub Kicinski 写道:
> > I see you mention that the work is not complete in the cover letter.
> > Either way this patch seems unnecessary, you can call the helpers
> > for "active" features like you do, but don't start by renaming the
> > existing field. The patch will be enormous.
> > .  
> I agree that this patch will be enormous,  I made this patch from suggestion
> from Andrew Lunn in RFCv3.[1]   Willit make people confused
> for help name inconsistent with feature name ?
> 
> [1]https://www.spinics.net/lists/netdev/msg777767.html

Thanks, not sure if I see a suggestion there from Andrew or just 
a question. Maybe you can add a comment instead to avoid surprising
people?