netdev - RE: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Mar 2022 07:11:01 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     Jakob Koschel <jakobkoschel@...il.com>
CC:     Kalle Valo <kvalo@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Mike Rapoport <rppt@...nel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        "Cristiano Giuffrida" <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: RE: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable


> -----Original Message-----
> From: Jakob Koschel <jakobkoschel@...il.com>
> Sent: Thursday, March 24, 2022 3:21 PM
> To: Pkshih <pkshih@...ltek.com>
> Cc: Kalle Valo <kvalo@...nel.org>; David S. Miller <davem@...emloft.net>; Jakub Kicinski <kuba@...nel.org>;
> Paolo Abeni <pabeni@...hat.com>; linux-wireless@...r.kernel.org; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; Mike Rapoport <rppt@...nel.org>; Brian Johannesmeyer
> <bjohannesmeyer@...il.com>; Cristiano Giuffrida <c.giuffrida@...nl>; Bos, H.J. <h.j.bos@...nl>; Jakob
> Koschel <jakobkoschel@...il.com>
> Subject: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable
> 
> To move the list iterator variable into the list_for_each_entry_*()
> macro in the future it should be avoided to use the list iterator
> variable after the loop body.
> 
> To *never* use the list iterator variable after the loop it was
> concluded to use a separate iterator variable instead of a
> found boolean [1].
> 
> This removes the need to use a found variable and simply checking if
> the variable was set, can determine if the break/goto was hit.
> 
> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
> Signed-off-by: Jakob Koschel <jakobkoschel@...il.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

Thanks.

[...]