lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Apr 2022 12:12:05 +0000 (UTC) From: Kalle Valo <kvalo@...nel.org> To: Jakob Koschel <jakobkoschel@...il.com> Cc: Ping-Ke Shih <pkshih@...ltek.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Mike Rapoport <rppt@...nel.org>, "Brian Johannesmeyer" <bjohannesmeyer@...il.com>, Cristiano Giuffrida <c.giuffrida@...nl>, "Bos, H.J." <h.j.bos@...nl>, Jakob Koschel <jakobkoschel@...il.com> Subject: Re: [PATCH] rtlwifi: replace usage of found with dedicated list iterator variable Jakob Koschel <jakobkoschel@...il.com> wrote: > To move the list iterator variable into the list_for_each_entry_*() > macro in the future it should be avoided to use the list iterator > variable after the loop body. > > To *never* use the list iterator variable after the loop it was > concluded to use a separate iterator variable instead of a > found boolean [1]. > > This removes the need to use a found variable and simply checking if > the variable was set, can determine if the break/goto was hit. > > Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ > Signed-off-by: Jakob Koschel <jakobkoschel@...il.com> > Acked-by: Ping-Ke Shih <pkshih@...ltek.com> Patch applied to wireless-next.git, thanks. a0ff2a87194a rtlwifi: replace usage of found with dedicated list iterator variable -- https://patchwork.kernel.org/project/linux-wireless/patch/20220324072124.62458-1-jakobkoschel@gmail.com/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists