lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Mar 2022 15:41:41 +0800 From: Meng Tang <tangmeng@...ontech.com> To: stas.yakovlev@...il.com, kvalo@...nel.org, kuba@...nel.org, pabeni@...hat.com Cc: linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Meng Tang <tangmeng@...ontech.com> Subject: [PATCH] ipw2200: Fix permissions setted by DEVICE_ATTR Because xcode_version and rtc only implement the show function and do not provide the store function, so ucode_version and rtc only need the read permission, not need the write permission more. So, remove the write permission from xcode_version and rtc. Signed-off-by: Meng Tang <tangmeng@...ontech.com> --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 6830e88c4ed6..fa4f38d54d0a 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -1578,7 +1578,7 @@ static ssize_t show_ucode_version(struct device *d, return sprintf(buf, "0x%08x\n", tmp); } -static DEVICE_ATTR(ucode_version, 0644, show_ucode_version, NULL); +static DEVICE_ATTR(ucode_version, 0444, show_ucode_version, NULL); static ssize_t show_rtc(struct device *d, struct device_attribute *attr, char *buf) @@ -1592,7 +1592,7 @@ static ssize_t show_rtc(struct device *d, struct device_attribute *attr, return sprintf(buf, "0x%08x\n", tmp); } -static DEVICE_ATTR(rtc, 0644, show_rtc, NULL); +static DEVICE_ATTR(rtc, 0444, show_rtc, NULL); /* * Add a device attribute to view/control the delay between eeprom -- 2.20.1
Powered by blists - more mailing lists