lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Mar 2022 20:37:45 +0100 From: Andrew Lunn <andrew@...n.ch> To: Meng Tang <tangmeng@...ontech.com> Cc: stas.yakovlev@...il.com, kvalo@...nel.org, kuba@...nel.org, pabeni@...hat.com, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ipw2200: Fix permissions setted by DEVICE_ATTR On Fri, Mar 25, 2022 at 03:41:41PM +0800, Meng Tang wrote: > Because xcode_version and rtc only implement the show function > and do not provide the store function, so ucode_version and rtc > only need the read permission, not need the write permission more. > > So, remove the write permission from xcode_version and rtc. > > Signed-off-by: Meng Tang <tangmeng@...ontech.com> > --- > drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c > index 6830e88c4ed6..fa4f38d54d0a 100644 > --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c > +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c > @@ -1578,7 +1578,7 @@ static ssize_t show_ucode_version(struct device *d, > return sprintf(buf, "0x%08x\n", tmp); > } > > -static DEVICE_ATTR(ucode_version, 0644, show_ucode_version, NULL); > +static DEVICE_ATTR(ucode_version, 0444, show_ucode_version, NULL); DEVICE_ATTR_RO() exists to make this more obvious. But it looks like you would need to rename the show_ucode_version() to ucode_version_show() in order to use it. Andrew
Powered by blists - more mailing lists