netdev - Re: [PATCH] ipw2200: Fix permissions setted by DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA++WF2NXLL4WjwyUYcBTJ9ogNAZnqZkU8KHqkvUbvE3k=RYroA@mail.gmail.com>
Date:   Tue, 29 Mar 2022 16:41:51 -0400
From:   Stanislav Yakovlev <stas.yakovlev@...il.com>
To:     Meng Tang <tangmeng@...ontech.com>
Cc:     kvalo@...nel.org, Jakub Kicinski <kuba@...nel.org>,
        pabeni@...hat.com, wireless <linux-wireless@...r.kernel.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipw2200: Fix permissions setted by DEVICE_ATTR

On Fri, 25 Mar 2022 at 03:42, Meng Tang <tangmeng@...ontech.com> wrote:
>
> Because xcode_version and rtc only implement the show function
> and do not provide the store function, so ucode_version and rtc
> only need the read permission, not need the write permission more.
>
> So, remove the write permission from xcode_version and rtc.
>
> Signed-off-by: Meng Tang <tangmeng@...ontech.com>
> ---
>  drivers/net/wireless/intel/ipw2x00/ipw2200.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Looks fine, thanks!

Stanislav.