netdev - Re: [PATCH] bnx2x: replace usage of found with dedicated list iterator variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 27 Mar 2022 23:32:17 +0200
From:   Jakob Koschel <jakobkoschel@...il.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     Ariel Elior <aelior@...vell.com>,
        Sudarsana Kalluru <skalluru@...vell.com>,
        Manish Chopra <manishc@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Mike Rapoport <rppt@...nel.org>,
        Brian Johannesmeyer <bjohannesmeyer@...il.com>,
        Cristiano Giuffrida <c.giuffrida@...nl>,
        "Bos, H.J." <h.j.bos@...nl>
Subject: Re: [PATCH] bnx2x: replace usage of found with dedicated list
 iterator variable

Hello,

> On 24. Mar 2022, at 11:46, Paolo Abeni <pabeni@...hat.com> wrote:
> 
> Hello,
> 
> On Thu, 2022-03-24 at 08:08 +0100, Jakob Koschel wrote:
>> To move the list iterator variable into the list_for_each_entry_*()
>> macro in the future it should be avoided to use the list iterator
>> variable after the loop body.
>> 
>> To *never* use the list iterator variable after the loop it was
>> concluded to use a separate iterator variable instead of a
>> found boolean [1].
>> 
>> This removes the need to use a found variable and simply checking if
>> the variable was set, can determine if the break/goto was hit.
>> 
>> Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
>> Signed-off-by: Jakob Koschel <jakobkoschel@...il.com>
> 
> This looks like a purely net-next change, and we are in the merge
> window: net-next is closed for the time being. Could you please re-post
> after net-next re-open?

Thanks for letting me know, I'll re-post after net-next is reopened.

> 
> Additionally, I suggest you to bundle the net-next patches in a single
> series, namely:

Are you saying having a single patchset for all /net and /drivers/net
related changes? This would also simplify a lot on my end.


> 
> bnx2x: replace usage of found with dedicated list iterator variable 
> octeontx2-pf: replace usage of found with dedicated list iterator variable 
> sctp: replace usage of found with dedicated list iterator variable 
> taprio: replace usage of found with dedicated list iterator variable 
> 
> that will simplify the processing, thanks!
> 
> Paolo

Thanks,
Jakob