netdev - Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 08:19:28 -0500
From:   Segher Boessenkool <segher@...nel.crashing.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Benjamin Stürz <benni@...erz.xyz>,
        Andrew Lunn <andrew@...n.ch>,
        linux-atm-general@...ts.sourceforge.net,
        linux-ia64@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-pci <linux-pci@...r.kernel.org>,
        Robert Moore <robert.moore@...el.com>,
        Harald Welte <laforge@...monks.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        "H. Peter Anvin" <hpa@...or.com>, wcn36xx@...ts.infradead.org,
        Pkshih <pkshih@...ltek.com>,
        "moderated list:ARM/SAMSUNG EXYNOS ARM ARCHITECTURES" 
        <linux-samsung-soc@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        linux-edac@...r.kernel.org,
        dennis.dalessandro@...nelisnetworks.com,
        linux-rdma <linux-rdma@...r.kernel.org>,
        Gregory CLEMENT <gregory.clement@...tlin.com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Russell King - ARM Linux <linux@...linux.org.uk>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Jason Gunthorpe <jgg@...pe.ca>, Ingo Molnar <mingo@...hat.com>,
        Chas Williams <3chas3@...il.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Jakub Kicinski <kuba@...nel.org>, pabeni@...hat.com,
        Len Brown <lenb@...nel.org>,
        mike.marciniszyn@...nelisnetworks.com,
        Robert Richter <rric@...nel.org>,
        Andrew Donnellan <ajd@...ux.ibm.com>, kvalo@...nel.org,
        linuxppc-dev <linuxppc-dev@...ts.ozlabs.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        loic.poulain@...aro.org, Borislav Petkov <bp@...en8.de>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        Simtec Linux Team <linux@...tec.co.uk>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        Karsten Keil <isdn@...ux-pingi.de>,
        Tony Luck <tony.luck@...el.com>,
        Nicolas Pitre <nico@...xnic.net>,
        gregkh <gregkh@...uxfoundation.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-wireless <linux-wireless@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        James Morse <james.morse@....com>,
        Networking <netdev@...r.kernel.org>,
        Frederic Barrat <fbarrat@...ux.ibm.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Pali Rohár <pali@...nel.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [PATCH 01/22] orion5x: Replace comments with C99 initializers

On Sat, Mar 26, 2022 at 08:23:31PM +0100, Arnd Bergmann wrote:
> On Sat, Mar 26, 2022 at 5:58 PM Benjamin Stürz <benni@...erz.xyz> wrote:
> >
> > This replaces comments with C99's designated
> > initializers because the kernel supports them now.
> 
> The change looks fine, but the comment looks misplaced, as enum initializers
> are not c99 feature.

Yes, it is from C89/C90.

> Also, the named array and struct intializers have been
> supported by gnu89 for a long time and widely used in the kernel, so it's
> not a recent change even for the others.

GCC supports this since 1998.  There was a syntax different from C99
designated initializers (".ans = 42") before (namely, "ans: 42").

1998 is long enough ago for all intents and purposes now of course ;-)


Segher