lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Mar 2022 14:47:05 +0100 From: Daniel Thompson <daniel.thompson@...aro.org> To: Benjamin Stürz <benni@...erz.xyz> Cc: sebastian.hesselbarth@...il.com, gregory.clement@...tlin.com, linux@...linux.org.uk, linux@...tec.co.uk, krzk@...nel.org, alim.akhtar@...sung.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com, hpa@...or.com, robert.moore@...el.com, rafael.j.wysocki@...el.com, lenb@...nel.org, 3chas3@...il.com, laforge@...monks.org, arnd@...db.de, gregkh@...uxfoundation.org, mchehab@...nel.org, tony.luck@...el.com, james.morse@....com, rric@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, mike.marciniszyn@...nelisnetworks.com, dennis.dalessandro@...nelisnetworks.com, jgg@...pe.ca, pali@...nel.org, dmitry.torokhov@...il.com, isdn@...ux-pingi.de, benh@...nel.crashing.org, fbarrat@...ux.ibm.com, ajd@...ux.ibm.com, davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com, nico@...xnic.net, loic.poulain@...aro.org, kvalo@...nel.org, pkshih@...ltek.com, bhelgaas@...gle.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org, linux-ia64@...r.kernel.org, linux-acpi@...r.kernel.org, devel@...ica.org, linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org, linux-edac@...r.kernel.org, linux-gpio@...r.kernel.org, linux-rdma@...r.kernel.org, linux-input@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, linux-media@...r.kernel.org, wcn36xx@...ts.infradead.org, linux-wireless@...r.kernel.org, linux-pci@...r.kernel.org Subject: Re: [PATCH 00/22] Replace comments with C99 initializers On Sun, Mar 27, 2022 at 02:46:00PM +0200, Benjamin Stürz wrote: > This patch series replaces comments with C99's designated initializers > in a few places. It also adds some enum initializers. This is my first > time contributing to the Linux kernel, therefore I'm probably doing a > lot of things the wrong way. I'm sorry for that. Welcome! > I've gotten a few emails so far stating that this patch series is > unnecessary. Yes, in fact this patch series is not necessary by itself, > but it could help me understand how the whole process works and maybe I > could help somewhere, where help is actually needed. Have you been told the series is unnecessary or too big? Although all patches represent a variant of the same mechanical transformation but they are mostly unrelated to each other and, if accepted, they will be applied by many different people. Taken as a whole presenting this to maintainers as a 22 patch set is too big. I'd recommend starting with a smaller patch or patch series where all the patches get picked up by the same maintainer. > This patch itself is a no-op. PATCH 0/XX is for the covering letter. You should generate a template for it using the --cover-letter option of git format-patch. That way patch 0 will contain the diffstat for the whole series (which is often useful to help understand what the series is for) and there is no need to make no-op changes. Daniel. > > Signed-off-by: Benjamin Stürz <benni@...erz.xyz> > --- > .gitignore | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.gitignore b/.gitignore > index 7afd412dadd2..706f667261eb 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -20,7 +20,7 @@ > *.dtb > *.dtbo > *.dtb.S > -*.dwo > +*.dwo > *.elf > *.gcno > *.gz > -- > 2.35.1
Powered by blists - more mailing lists