netdev - Re: [PATCH bpf 0/4] xsk: another round of fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220328142123.170157-1-maciej.fijalkowski@intel.com>
Date:   Mon, 28 Mar 2022 16:48:44 +0200
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        netdev@...r.kernel.org, magnus.karlsson@...el.com, bjorn@...nel.org
Subject: Re: [PATCH bpf 0/4] xsk: another round of fixes

From: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Date: Mon, 28 Mar 2022 16:21:19 +0200

> Hello,
> 
> yet another fixes for XSK from Magnus and me.
> 
> Magnus addresses the fact that xp_alloc() can return NULL, so this needs
> to be handled to avoid clearing entries in the SW ring on driver side.
> Then he addresses the off-by-one problem in Tx desc cleaning routine for
> ice ZC driver.
> 
> From my side, I am adding protection to ZC Rx processing loop so that
> cleaning of descriptors wouldn't go over already processed entries.
> Then I also fix an issue with assigning XSK pool to Tx queues.

Nice, thanks!
For the series:

Acked-by: Alexander Lobakin <alexandr.lobakin@...el.com>

> 
> This is directed to bpf tree.
> 
> Thanks!
> 
> Maciej Fijalkowski (2):
>   ice: xsk: stop Rx processing when ntc catches ntu
>   ice: xsk: fix indexing in ice_tx_xsk_pool()
> 
> Magnus Karlsson (2):
>   xsk: do not write NULL in SW ring at allocation failure
>   ice: xsk: eliminate unnecessary loop iteration
> 
>  drivers/net/ethernet/intel/ice/ice.h     | 2 +-
>  drivers/net/ethernet/intel/ice/ice_xsk.c | 5 ++++-
>  net/xdp/xsk_buff_pool.c                  | 8 ++++++--
>  3 files changed, 11 insertions(+), 4 deletions(-)
> 
> -- 
> 2.27.0

Thanks,
Al