netdev - Re: [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 28 Mar 2022 16:41:48 +0200
From:   Clément Léger <clement.leger@...tlin.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Horatiu Vultur <horatiu.vultur@...rochip.com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Allan Nielsen <allan.nielsen@...rochip.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [net-next 1/5] net: mdio: fwnode: add fwnode_mdiobus_register()

Le Mon, 28 Mar 2022 16:12:33 +0200,
Andrew Lunn <andrew@...n.ch> a écrit :

> > With this series, fwnode_mdiobus_register() supports exactly the same
> > subset that is supported by of_mdiobus_register().  
> 
> I need to see the side-by-side conversion. But it looked to me you did
> not support everything in DT.

I splat the conversion as you requested and it make it clear that it's
a 1:1 conversion. But indeed, it will be better by looking at patches.

> 
> And another question is, should it support everything in DT. The DT
> binding has things which are deprecated. We have to support them in
> DT, they are ABI. But anything new should not be using them.

Ok, so maybe, the fwnode support should stop supporting these
deprecated features. From what I can see, there is at least the
following two things:

- Whitelist id table (seems to check legacy compatible strings)
- Scanning of child nodes that don't have a reg property. reg is
  specified as required in the bindings so it's probably not a good
  thing to keep that.

So maybe these features can be removed from the fwnode support.

Thanks,

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com