lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Mar 2022 05:20:40 +0900 From: Damien Le Moal <damien.lemoal@...nsource.wdc.com> To: Andrew Lunn <andrew@...n.ch> Cc: Michael Chan <michael.chan@...adcom.com>, "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Netdev <netdev@...r.kernel.org>, Pavan Chebbi <pavan.chebbi@...adcom.com> Subject: Re: [PATCH v2] net: bnxt_ptp: fix compilation error On 3/28/22 21:46, Andrew Lunn wrote: >> The call to bnxt_ptp_cfg_pin() after the swith will return -ENOTSUPP for >> invalid pin IDs. So I did not feel like adding more changes was necessary. >> >> We can return an error if you insist, but what should it be ? -EINVAL ? >> -ENODEV ? -ENOTSUPP ? Given that bnxt_ptp_cfg_pin() return -ENOTSUPP, we >> could use that code. > > https://elixir.bootlin.com/linux/v5.17.1/source/include/linux/errno.h#L23 > > ENOTSUPP is an NFS only error code. It should not be used anywhere > else. EOPNOTSUPP is the generic error that should be used. However, > don't replace an ENOTSUPP with an EOPNOTSUPP without considering ABI. Typo... the current error for invalid pin IDs is EOPNOTSUPP, not ENOTSUPP. So I reused EOPNOTSUPP in the patch. > > Andrew -- Damien Le Moal Western Digital Research
Powered by blists - more mailing lists