lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 28 Mar 2022 14:46:57 +0200
From:   Andrew Lunn <>
To:     Damien Le Moal <>
Cc:     Michael Chan <>,
        "David S . Miller" <>,
        Jakub Kicinski <>,
        Paolo Abeni <>,
        Netdev <>,
        Pavan Chebbi <>
Subject: Re: [PATCH v2] net: bnxt_ptp: fix compilation error

> The call to bnxt_ptp_cfg_pin() after the swith will return -ENOTSUPP for
> invalid pin IDs. So I did not feel like adding more changes was necessary.
> We can return an error if you insist, but what should it be ? -EINVAL ?
> -ENODEV ? -ENOTSUPP ? Given that bnxt_ptp_cfg_pin() return -ENOTSUPP, we
> could use that code.

ENOTSUPP is an NFS only error code. It should not be used anywhere
else. EOPNOTSUPP is the generic error that should be used. However,
don't replace an ENOTSUPP with an EOPNOTSUPP without considering ABI.


Powered by blists - more mailing lists