netdev - Re: [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YkVUWV0czTzo6MrJ@shell.armlinux.org.uk>
Date:   Thu, 31 Mar 2022 08:12:25 +0100
From:   "Russell King (Oracle)" <linux@...linux.org.uk>
To:     Dylan Hung <dylan_hung@...eedtech.com>
Cc:     robh+dt@...nel.org, joel@....id.au, andrew@...id.au,
        andrew@...n.ch, hkallweit1@...il.com, davem@...emloft.net,
        kuba@...nel.org, pabeni@...hat.com, p.zabel@...gutronix.de,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, BMC-SW@...eedtech.com
Subject: Re: [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO

Hi,

On Fri, Mar 25, 2022 at 12:14:50PM +0800, Dylan Hung wrote:
> Add reset assertion/deassertion for Aspeed MDIO.  There are 4 MDIO
> controllers embedded in Aspeed AST2600 SOC and share one reset control
> register SCU50[3].  To work with old DT blobs which don't have the reset
> property, devm_reset_control_get_optional_shared is used in this change.
> 
> Signed-off-by: Dylan Hung <dylan_hung@...eedtech.com>
> Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

Should this really be specific to one driver rather than being handled
in the core mdio code?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!