[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <HK0PR06MB2834DA2D814BC55A10F6584D9CE69@HK0PR06MB2834.apcprd06.prod.outlook.com>
Date: Thu, 7 Apr 2022 06:29:26 +0000
From: Dylan Hung <dylan_hung@...eedtech.com>
To: Russell King <linux@...linux.org.uk>
CC: "robh+dt@...nel.org" <robh+dt@...nel.org>,
"joel@....id.au" <joel@....id.au>,
"andrew@...id.au" <andrew@...id.au>,
"andrew@...n.ch" <andrew@...n.ch>,
"hkallweit1@...il.com" <hkallweit1@...il.com>,
"davem@...emloft.net" <davem@...emloft.net>,
"kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
BMC-SW <BMC-SW@...eedtech.com>
Subject: RE: [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO
Hi Russell,
> -----Original Message-----
> From: Russell King [mailto:linux@...linux.org.uk]
> Sent: 2022年3月31日 3:12 PM
> To: Dylan Hung <dylan_hung@...eedtech.com>
> Cc: robh+dt@...nel.org; joel@....id.au; andrew@...id.au; andrew@...n.ch;
> hkallweit1@...il.com; davem@...emloft.net; kuba@...nel.org;
> pabeni@...hat.com; p.zabel@...gutronix.de; devicetree@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linux-aspeed@...ts.ozlabs.org;
> linux-kernel@...r.kernel.org; netdev@...r.kernel.org; BMC-SW
> <BMC-SW@...eedtech.com>
> Subject: Re: [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO
>
> Hi,
>
> On Fri, Mar 25, 2022 at 12:14:50PM +0800, Dylan Hung wrote:
> > Add reset assertion/deassertion for Aspeed MDIO. There are 4 MDIO
> > controllers embedded in Aspeed AST2600 SOC and share one reset control
> > register SCU50[3]. To work with old DT blobs which don't have the
> > reset property, devm_reset_control_get_optional_shared is used in this
> change.
> >
> > Signed-off-by: Dylan Hung <dylan_hung@...eedtech.com>
> > Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>
>
> Should this really be specific to one driver rather than being handled in the
> core mdio code?
>
Is the core mdio code able to know the reset is shared or exclusive? I supposed that
the reset property is hardware dependent. Did I get that right?
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists