netdev - ordering of check in phy_state_machine() since 06edf1a940be0633499e2feea31d380375a22bd9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbaafccd-60ee-1c29-a014-ec50661f58eb@suse.com>
Date:   Thu, 31 Mar 2022 12:33:30 +0200
From:   Oliver Neukum <oneukum@...e.com>
To:     Oleksij Rempel <linux@...pel-privat.de>
CC:     Lukas Wunner <lukas@...ner.de>,
        Oleksij Rempel <o.rempel@...gutronix.de>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Andrew Lunn <andrew@...n.ch>
Subject: ordering of check in phy_state_machine() since
 06edf1a940be0633499e2feea31d380375a22bd9

Hi,

looking at this I wonder whether the check isn't too late.
Do you really want to restart autonegotiation although
you know that the device is gone?

    Regards
        Oliver