lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 31 Mar 2022 12:51:34 +0200
From:   Lukas Wunner <>
To:     Oliver Neukum <>
Cc:     Oleksij Rempel <>,
        Oleksij Rempel <>,
        "" <>,
        Andrew Lunn <>
Subject: Re: ordering of check in phy_state_machine() since

On Thu, Mar 31, 2022 at 12:33:30PM +0200, Oliver Neukum wrote:
> looking at this I wonder whether the check isn't too late.
> Do you really want to restart autonegotiation although
> you know that the device is gone?

Ignoring PHY_CABLETEST for a moment, needs_aneg is only set to
true if state is PHY_UP, i.e. the netdev was just opened.

If the USB adapter is unplugged at that moment, the expectation
is that phy_start_aneg() returns -ENODEV, so we bail out of

Commit 06edf1a940be looks fine to me.



Powered by blists - more mailing lists