netdev - RE: [PATCH v8 net-next 4/4] net: axiemac: use a phandle to reference pcs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA1PR02MB85609D7ECEF5454B6D84BAC9C7E49@SA1PR02MB8560.namprd02.prod.outlook.com>
Date:   Tue, 5 Apr 2022 12:23:28 +0000
From:   Radhey Shyam Pandey <radheys@...inx.com>
To:     Andy Chiu <andy.chiu@...ive.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Michal Simek <michals@...inx.com>
CC:     "andrew@...n.ch" <andrew@...n.ch>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Greentime Hu <greentime.hu@...ive.com>,
        Robert Hancock <robert.hancock@...ian.com>
Subject: RE: [PATCH v8 net-next 4/4] net: axiemac: use a phandle to reference
 pcs_phy

> -----Original Message-----
> From: Andy Chiu <andy.chiu@...ive.com>
> Sent: Tuesday, April 5, 2022 2:49 PM
> To: davem@...emloft.net; Michal Simek <michals@...inx.com>; Radhey
> Shyam Pandey <radheys@...inx.com>
> Cc: andrew@...n.ch; kuba@...nel.org; pabeni@...hat.com;
> robh+dt@...nel.org; krzk+dt@...nel.org; linux@...linux.org.uk;
> netdev@...r.kernel.org; devicetree@...r.kernel.org; Andy Chiu
> <andy.chiu@...ive.com>; Greentime Hu <greentime.hu@...ive.com>; Robert
> Hancock <robert.hancock@...ian.com>
> Subject: [PATCH v8 net-next 4/4] net: axiemac: use a phandle to reference
> pcs_phy
> 
> In some SGMII use cases where both a fixed link external PHY and the internal
> PCS/PMA PHY need to be configured, we should explicitly use a phandle "pcs-
> phy" to get the reference to the PCS/PMA PHY. Otherwise, the driver would
> use "phy-handle" in the DT as the reference to both the external and the
> internal PCS/PMA PHY.
> 
> In other cases where the core is connected to a SFP cage, we could still point
> phy-handle to the intenal PCS/PMA PHY, and let the driver connect to the SFP

Internal

> module, if exist, via phylink.
> 
> Signed-off-by: Andy Chiu <andy.chiu@...ive.com>
> Reviewed-by: Greentime Hu <greentime.hu@...ive.com>
> Reviewed-by: Robert Hancock <robert.hancock@...ian.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>

> ---
>  drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> index 3daef64a85bd..d6fc3f7acdf0 100644
> --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
> @@ -2071,9 +2071,16 @@ static int axienet_probe(struct platform_device
> *pdev)
> 
>  	if (lp->phy_mode == PHY_INTERFACE_MODE_SGMII ||
>  	    lp->phy_mode == PHY_INTERFACE_MODE_1000BASEX) {
> -		np = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
> +		np = of_parse_phandle(pdev->dev.of_node, "pcs-handle", 0);
>  		if (!np) {
> -			dev_err(&pdev->dev, "phy-handle required for
> 1000BaseX/SGMII\n");
> +			/* Deprecated: Always use "pcs-handle" for pcs_phy.
> +			 * Falling back to "phy-handle" here is only for
> +			 * backward compatibility with old device trees.
> +			 */
> +			np = of_parse_phandle(pdev->dev.of_node, "phy-
> handle", 0);
> +		}
> +		if (!np) {
> +			dev_err(&pdev->dev, "pcs-handle (preferred) or phy-
> handle required
> +for 1000BaseX/SGMII\n");
>  			ret = -EINVAL;
>  			goto cleanup_mdio;
>  		}
> --
> 2.34.1