netdev - Re: [PATCH] qed: remove an unneed NULL check on list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220405182641.08cd18ff@kernel.org>
Date:   Tue, 5 Apr 2022 18:26:41 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xiaomeng Tong <xiam0nd.tong@...il.com>
Cc:     aelior@...vell.com, manishc@...vell.com, davem@...emloft.net,
        pabeni@...hat.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator

On Tue,  5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
>  struct pci_dev *qed_validate_ndev(struct net_device *ndev)
>  {
> -	struct pci_dev *pdev = NULL;
> +	struct pci_dev *pdev;
>  	struct net_device *upper;

Please keep the longest-to-shortest ordering of variable declaration
lines.