[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20220407012207.14442-1-xiam0nd.tong@gmail.com>
Date: Thu, 7 Apr 2022 09:22:07 +0800
From: Xiaomeng Tong <xiam0nd.tong@...il.com>
To: kuba@...nel.org
Cc: aelior@...vell.com, davem@...emloft.net,
linux-kernel@...r.kernel.org, manishc@...vell.com,
netdev@...r.kernel.org, pabeni@...hat.com, xiam0nd.tong@...il.com
Subject: Re: [PATCH] qed: remove an unneed NULL check on list iterator
On Tue, 5 Apr 2022 18:26:41 -0700, Jakub Kicinski wrote:
> On Tue, 5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
> > struct pci_dev *qed_validate_ndev(struct net_device *ndev)
> > {
> > - struct pci_dev *pdev = NULL;
> > + struct pci_dev *pdev;
> > struct net_device *upper;
>
> Please keep the longest-to-shortest ordering of variable declaration
> lines.
I have fix it in v2 patch [1], as you suggested. Please check it.
Thank you very much.
[1] https://lore.kernel.org/lkml/20220406015921.29267-1-xiam0nd.tong@gmail.com/
--
Xiaomeng Tong
Powered by blists - more mailing lists