netdev - Re: [PATCH bpf-next v2 2/7] bpf: per-cgroup lsm flavor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 7 Apr 2022 02:42:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH bpf-next v2 2/7] bpf: per-cgroup lsm flavor

Hi Stanislav,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/bpf-cgroup_sock-lsm-flavor/20220406-162419
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: powerpc-buildonly-randconfig-r003-20220406 (https://download.01.org/0day-ci/archive/20220407/202204070201.lzjdBJq0-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b416dabea64e9ab8418ffb26990f2d303b968f2d
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Stanislav-Fomichev/bpf-cgroup_sock-lsm-flavor/20220406-162419
        git checkout b416dabea64e9ab8418ffb26990f2d303b968f2d
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   powerpc-linux-ld: kernel/bpf/trampoline.o: in function `bpf_trampoline_compute_key':
>> include/linux/bpf_verifier.h:540: undefined reference to `btf_obj_id'
>> powerpc-linux-ld: include/linux/bpf_verifier.h:540: undefined reference to `btf_obj_id'


vim +540 include/linux/bpf_verifier.h

ab3f0063c48c26c Jakub Kicinski          2017-11-03  521  
be80a1d3f9dbe5a Daniel Borkmann         2022-01-10  522  int check_ptr_off_reg(struct bpf_verifier_env *env,
51c39bb1d5d105a Alexei Starovoitov      2020-01-09  523  		      const struct bpf_reg_state *reg, int regno);
25b35dd28138f61 Kumar Kartikeya Dwivedi 2022-03-05  524  int check_func_arg_reg_off(struct bpf_verifier_env *env,
25b35dd28138f61 Kumar Kartikeya Dwivedi 2022-03-05  525  			   const struct bpf_reg_state *reg, int regno,
24d5bb806c7e2c0 Kumar Kartikeya Dwivedi 2022-03-05  526  			   enum bpf_arg_type arg_type,
24d5bb806c7e2c0 Kumar Kartikeya Dwivedi 2022-03-05  527  			   bool is_release_func);
d583691c47dc042 Kumar Kartikeya Dwivedi 2022-01-14  528  int check_kfunc_mem_size_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg,
d583691c47dc042 Kumar Kartikeya Dwivedi 2022-01-14  529  			     u32 regno);
e5069b9c23b3857 Dmitrii Banshchikov     2021-02-13  530  int check_mem_reg(struct bpf_verifier_env *env, struct bpf_reg_state *reg,
e5069b9c23b3857 Dmitrii Banshchikov     2021-02-13  531  		   u32 regno, u32 mem_size);
51c39bb1d5d105a Alexei Starovoitov      2020-01-09  532  
f7b12b6fea00988 Toke Høiland-Jørgensen  2020-09-25  533  /* this lives here instead of in bpf.h because it needs to dereference tgt_prog */
f7b12b6fea00988 Toke Høiland-Jørgensen  2020-09-25  534  static inline u64 bpf_trampoline_compute_key(const struct bpf_prog *tgt_prog,
22dc4a0f5ed11b6 Andrii Nakryiko         2020-12-03  535  					     struct btf *btf, u32 btf_id)
f7b12b6fea00988 Toke Høiland-Jørgensen  2020-09-25  536  {
22dc4a0f5ed11b6 Andrii Nakryiko         2020-12-03  537  	if (tgt_prog)
22dc4a0f5ed11b6 Andrii Nakryiko         2020-12-03  538  		return ((u64)tgt_prog->aux->id << 32) | btf_id;
22dc4a0f5ed11b6 Andrii Nakryiko         2020-12-03  539  	else
22dc4a0f5ed11b6 Andrii Nakryiko         2020-12-03 @540  		return ((u64)btf_obj_id(btf) << 32) | 0x80000000 | btf_id;
f7b12b6fea00988 Toke Høiland-Jørgensen  2020-09-25  541  }
f7b12b6fea00988 Toke Høiland-Jørgensen  2020-09-25  542  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp