netdev - Re: [PATCH bpf] xsk: fix l2fwd for copy mode + busy poll combo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164936581210.6878.17567459374327495155.git-patchwork-notify@kernel.org>
Date:   Thu, 07 Apr 2022 21:10:12 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc:     bpf@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        netdev@...r.kernel.org, magnus.karlsson@...el.com,
        bjorn@...nel.org, brouer@...hat.com, alexandr.lobakin@...el.com
Subject: Re: [PATCH bpf] xsk: fix l2fwd for copy mode + busy poll combo

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Wed,  6 Apr 2022 17:58:04 +0200 you wrote:
> While checking AF_XDP copy mode combined with busy poll, strange
> results were observed. rxdrop and txonly scenarios worked fine, but
> l2fwd broke immediately.
> 
> After a deeper look, it turned out that for l2fwd, Tx side was exiting
> early due to xsk_no_wakeup() returning true and in the end
> xsk_generic_xmit() was never called. Note that AF_XDP Tx in copy mode is
> syscall steered, so the current behavior is broken.
> 
> [...]

Here is the summary with links:
  - [bpf] xsk: fix l2fwd for copy mode + busy poll combo
    https://git.kernel.org/bpf/bpf/c/8de8b71b787f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html