[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8d103ac8-2433-f2ab-522c-9316445e3a31@mojatatu.com>
Date: Thu, 7 Apr 2022 17:15:58 -0400
From: Jamal Hadi Salim <jhs@...atatu.com>
To: undisclosed-recipients:;
Subject: Re: [PATCH net-next 00/14] net/sched: Better error reporting for
offload failures
Excellent work.
Small comment, maybe a better message is:
"Failed to setup offload flow action"?
cheers,
jamal
On 2022-04-07 03:35, Ido Schimmel wrote:
> This patchset improves error reporting to user space when offload fails
> during the flow action setup phase. That is, when failures occur in the
> actions themselves, even before calling device drivers. Requested /
> reported in [1].
>
> This is done by passing extack to the offload_act_setup() callback and
> making use of it in the various actions.
>
> Patches #1-#2 change matchall and flower to log error messages to user
> space in accordance with the verbose flag.
>
> Patch #3 passes extack to the offload_act_setup() callback from the
> various call sites, including matchall and flower.
>
> Patches #4-#11 make use of extack in the various actions to report
> offload failures.
>
> Patch #12 adds an error message when the action does not support offload
> at all.
>
> Patches #13-#14 change matchall and flower to stop overwriting more
> specific error messages.
>
> [1] https://lore.kernel.org/netdev/20220317185249.5mff5u2x624pjewv@skbuf/
>
> Ido Schimmel (14):
> net/sched: matchall: Take verbose flag into account when logging error
> messages
> net/sched: flower: Take verbose flag into account when logging error
> messages
> net/sched: act_api: Add extack to offload_act_setup() callback
> net/sched: act_gact: Add extack messages for offload failure
> net/sched: act_mirred: Add extack message for offload failure
> net/sched: act_mpls: Add extack messages for offload failure
> net/sched: act_pedit: Add extack message for offload failure
> net/sched: act_police: Add extack messages for offload failure
> net/sched: act_skbedit: Add extack messages for offload failure
> net/sched: act_tunnel_key: Add extack message for offload failure
> net/sched: act_vlan: Add extack message for offload failure
> net/sched: cls_api: Add extack message for unsupported action offload
> net/sched: matchall: Avoid overwriting error messages
> net/sched: flower: Avoid overwriting error messages
>
> include/net/act_api.h | 3 ++-
> include/net/pkt_cls.h | 6 ++++--
> include/net/tc_act/tc_gact.h | 15 +++++++++++++++
> include/net/tc_act/tc_skbedit.h | 12 ++++++++++++
> net/sched/act_api.c | 4 ++--
> net/sched/act_csum.c | 3 ++-
> net/sched/act_ct.c | 3 ++-
> net/sched/act_gact.c | 13 ++++++++++++-
> net/sched/act_gate.c | 3 ++-
> net/sched/act_mirred.c | 4 +++-
> net/sched/act_mpls.c | 10 +++++++++-
> net/sched/act_pedit.c | 4 +++-
> net/sched/act_police.c | 20 ++++++++++++++++----
> net/sched/act_sample.c | 3 ++-
> net/sched/act_skbedit.c | 10 +++++++++-
> net/sched/act_tunnel_key.c | 4 +++-
> net/sched/act_vlan.c | 4 +++-
> net/sched/cls_api.c | 22 ++++++++++++++--------
> net/sched/cls_flower.c | 14 ++++++--------
> net/sched/cls_matchall.c | 19 +++++++------------
> 20 files changed, 128 insertions(+), 48 deletions(-)
>
Powered by blists - more mailing lists