netdev - Re: [PATCH net] net/sched: flower: fix parsing of ethertype following VLAN header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 08 Apr 2022 11:20:13 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     davem@...emloft.net, kuba@...nel.org, xiyou.wangcong@...il.com,
        jhs@...atatu.com, jiri@...nulli.us, netdev@...r.kernel.org,
        maord@...dia.com, jiri@...dia.com
Subject: Re: [PATCH net] net/sched: flower: fix parsing of ethertype following
 VLAN header

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Wed, 6 Apr 2022 14:22:41 +0300 you wrote:
> A tc flower filter matching TCA_FLOWER_KEY_VLAN_ETH_TYPE is expected to
> match the L2 ethertype following the first VLAN header, as confirmed by
> linked discussion with the maintainer. However, such rule also matches
> packets that have additional second VLAN header, even though filter has
> both eth_type and vlan_ethtype set to "ipv4". Looking at the code this
> seems to be mostly an artifact of the way flower uses flow dissector.
> First, even though looking at the uAPI eth_type and vlan_ethtype appear
> like a distinct fields, in flower they are all mapped to the same
> key->basic.n_proto. Second, flow dissector skips following VLAN header as
> no keys for FLOW_DISSECTOR_KEY_CVLAN are set and eventually assigns the
> value of n_proto to last parsed header. With these, such filters ignore any
> headers present between first VLAN header and first "non magic"
> header (ipv4 in this case) that doesn't result
> FLOW_DISSECT_RET_PROTO_AGAIN.
> 
> [...]

Here is the summary with links:
  - [net] net/sched: flower: fix parsing of ethertype following VLAN header
    https://git.kernel.org/netdev/net/c/2105f700b53c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html