netdev - Re: [PATCH net-next 00/14] net/sched: Better error reporting for offload failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YlCEL1tW8lu0yRtC@t14s.localdomain>
Date:   Fri, 8 Apr 2022 15:51:27 -0300
From:   Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
To:     Ido Schimmel <idosch@...dia.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        pabeni@...hat.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, petrm@...dia.com, jianbol@...dia.com,
        roid@...dia.com, vladbu@...dia.com, olteanv@...il.com,
        simon.horman@...igine.com, baowen.zheng@...igine.com
Subject: Re: [PATCH net-next 00/14] net/sched: Better error reporting for
 offload failures

On Thu, Apr 07, 2022 at 10:35:19AM +0300, Ido Schimmel wrote:
> This patchset improves error reporting to user space when offload fails
> during the flow action setup phase. That is, when failures occur in the
> actions themselves, even before calling device drivers. Requested /
> reported in [1].
> 
> This is done by passing extack to the offload_act_setup() callback and
> making use of it in the various actions.
> 
> Patches #1-#2 change matchall and flower to log error messages to user
> space in accordance with the verbose flag.
> 
> Patch #3 passes extack to the offload_act_setup() callback from the
> various call sites, including matchall and flower.
> 
> Patches #4-#11 make use of extack in the various actions to report
> offload failures.
> 
> Patch #12 adds an error message when the action does not support offload
> at all.
> 
> Patches #13-#14 change matchall and flower to stop overwriting more
> specific error messages.
> 
> [1] https://lore.kernel.org/netdev/20220317185249.5mff5u2x624pjewv@skbuf/

Seems like tc is almost becoming user friendly!? :)

post-merge review FWIW,
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@...il.com>