netdev - Re: [PATCH net-next] fou: Remove XRFM from NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 8 Apr 2022 14:33:49 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Coco Li <lixiaoyan@...gle.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
        willem de bruijn <willemb@...gle.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Greg Thelen <gthelen@...gle.com>
Subject: Re: [PATCH net-next] fou: Remove XRFM from NET_FOU Kconfig

On Thu,  7 Apr 2022 10:15:54 -0700 Coco Li wrote:
> XRFM is no longer needed for configuring FOU tunnels
> (CONFIG_NET_FOU_IP_TUNNELS), remove from Kconfig.

What's the full story? The original code mentions udp_encap_rcv 
but would be used to note where that dependency got removed.

> Built and installed kernel and setup GUE/FOU tunnels.
> 
> Signed-off-by: Coco Li <lixiaoyan@...gle.com>
> ---
>  net/ipv4/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/ipv4/Kconfig b/net/ipv4/Kconfig
> index 87983e70f03f..e983bb0c5012 100644
> --- a/net/ipv4/Kconfig
> +++ b/net/ipv4/Kconfig
> @@ -321,7 +321,6 @@ config NET_UDP_TUNNEL
>  
>  config NET_FOU
>  	tristate "IP: Foo (IP protocols) over UDP"
> -	select XFRM
>  	select NET_UDP_TUNNEL
>  	help
>  	  Foo over UDP allows any IP protocol to be directly encapsulated

I think we can also remove the include of xfrm.h from fou.c ?