netdev - Re: [PATCH net] net/sched: fix initialization order when updating chain 0 head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <164945521197.24737.6537631009276589069.git-patchwork-notify@kernel.org>
Date:   Fri, 08 Apr 2022 22:00:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     netdev@...r.kernel.org, vladbu@...dia.com, dcaratti@...hat.com,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        lariel@...dia.com
Subject: Re: [PATCH net] net/sched: fix initialization order when updating chain 0
 head

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Thu,  7 Apr 2022 11:29:23 -0300 you wrote:
> Currently, when inserting a new filter that needs to sit at the head
> of chain 0, it will first update the heads pointer on all devices using
> the (shared) block, and only then complete the initialization of the new
> element so that it has a "next" element.
> 
> This can lead to a situation that the chain 0 head is propagated to
> another CPU before the "next" initialization is done. When this race
> condition is triggered, packets being matched on that CPU will simply
> miss all other filters, and will flow through the stack as if there were
> no other filters installed. If the system is using OVS + TC, such
> packets will get handled by vswitchd via upcall, which results in much
> higher latency and reordering. For other applications it may result in
> packet drops.
> 
> [...]

Here is the summary with links:
  - [net] net/sched: fix initialization order when updating chain 0 head
    https://git.kernel.org/netdev/net/c/e65812fd22eb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html