netdev - Re: [PATCH net-next 1/5] ipv4: Use dscp_t in struct fib_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c4626f31-f986-b4e3-f72d-8faacafe565d@kernel.org>
Date:   Sun, 10 Apr 2022 11:58:43 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Guillaume Nault <gnault@...hat.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Taras Chornyi <tchornyi@...vell.com>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH net-next 1/5] ipv4: Use dscp_t in struct fib_rt_info

On 4/8/22 2:08 PM, Guillaume Nault wrote:
> Use the new dscp_t type to replace the tos field of struct fib_rt_info.
> This ensures ECN bits are ignored and makes it compatible with the
> fa_dscp field of struct fib_alias.
> 
> This also allows sparse to flag potential incorrect uses of DSCP and
> ECN bits.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_router.c | 3 ++-
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c   | 7 ++++---
>  drivers/net/netdevsim/fib.c                             | 5 +++--
>  include/net/ip_fib.h                                    | 2 +-
>  net/ipv4/fib_semantics.c                                | 4 ++--
>  net/ipv4/fib_trie.c                                     | 6 +++---
>  net/ipv4/route.c                                        | 4 ++--
>  7 files changed, 17 insertions(+), 14 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>