netdev - Re: [PATCH net-next 2/5] ipv4: Use dscp_t in struct fib_entry_notifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b37040f-ba15-7f26-72ad-47e7d6d9b174@kernel.org>
Date:   Sun, 10 Apr 2022 11:59:33 -0600
From:   David Ahern <dsahern@...nel.org>
To:     Guillaume Nault <gnault@...hat.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, Taras Chornyi <tchornyi@...vell.com>,
        Ido Schimmel <idosch@...dia.com>,
        Petr Machata <petrm@...dia.com>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH net-next 2/5] ipv4: Use dscp_t in struct
 fib_entry_notifier_info

On 4/8/22 2:08 PM, Guillaume Nault wrote:
> Use the new dscp_t type to replace the tos field of struct
> fib_entry_notifier_info. This ensures ECN bits are ignored and makes it
> compatible with the dscp field of struct fib_rt_info.
> 
> This also allows sparse to flag potential incorrect uses of DSCP and
> ECN bits.
> 
> Signed-off-by: Guillaume Nault <gnault@...hat.com>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_router.c | 6 +++---
>  drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c   | 6 +++---
>  drivers/net/netdevsim/fib.c                             | 4 ++--
>  include/net/ip_fib.h                                    | 2 +-
>  net/ipv4/fib_trie.c                                     | 4 ++--
>  5 files changed, 11 insertions(+), 11 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@...nel.org>