| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 11 Apr 2022 03:59:13 +0800
From: kernel test robot <lkp@...el.com>
To: Oliver Hartkopp <socketcan@...tkopp.net>, netdev@...r.kernel.org,
kuba@...nel.org, davem@...emloft.net
Cc: kbuild-all@...ts.01.org, Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH net-next] net: remove noblock parameter from recvmsg()
entities
Hi Oliver,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Oliver-Hartkopp/net-remove-noblock-parameter-from-recvmsg-entities/20220411-025612
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 516a2f1f6f3ce1a87931579cc21de6e7e33440bd
config: alpha-defconfig (https://download.01.org/0day-ci/archive/20220411/202204110353.rQbTNo81-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/471dc1b8019d39c987dbdac34bb57678745739c8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Oliver-Hartkopp/net-remove-noblock-parameter-from-recvmsg-entities/20220411-025612
git checkout 471dc1b8019d39c987dbdac34bb57678745739c8
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash net/sunrpc/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All error/warnings (new ones prefixed by >>):
net/sunrpc/xprtsock.c: In function 'xs_udp_data_receive':
>> net/sunrpc/xprtsock.c:1340:43: warning: passing argument 3 of 'skb_recv_udp' makes pointer from integer without a cast [-Wint-conversion]
1340 | skb = skb_recv_udp(sk, 0, 1, &err);
| ^
| |
| int
In file included from net/sunrpc/xprtsock.c:48:
include/net/udp.h:256:49: note: expected 'int *' but argument is of type 'int'
256 | int *err)
| ~~~~~^~~
>> net/sunrpc/xprtsock.c:1340:23: error: too many arguments to function 'skb_recv_udp'
1340 | skb = skb_recv_udp(sk, 0, 1, &err);
| ^~~~~~~~~~~~
In file included from net/sunrpc/xprtsock.c:48:
include/net/udp.h:255:31: note: declared here
255 | static inline struct sk_buff *skb_recv_udp(struct sock *sk, unsigned int flags,
| ^~~~~~~~~~~~
--
net/sunrpc/svcsock.c: In function 'svc_udp_recvfrom':
>> net/sunrpc/svcsock.c:467:44: warning: passing argument 3 of 'skb_recv_udp' makes pointer from integer without a cast [-Wint-conversion]
467 | skb = skb_recv_udp(svsk->sk_sk, 0, 1, &err);
| ^
| |
| int
In file included from net/sunrpc/svcsock.c:43:
include/net/udp.h:256:49: note: expected 'int *' but argument is of type 'int'
256 | int *err)
| ~~~~~^~~
>> net/sunrpc/svcsock.c:467:15: error: too many arguments to function 'skb_recv_udp'
467 | skb = skb_recv_udp(svsk->sk_sk, 0, 1, &err);
| ^~~~~~~~~~~~
In file included from net/sunrpc/svcsock.c:43:
include/net/udp.h:255:31: note: declared here
255 | static inline struct sk_buff *skb_recv_udp(struct sock *sk, unsigned int flags,
| ^~~~~~~~~~~~
vim +/skb_recv_udp +1340 net/sunrpc/xprtsock.c
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1328
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1329 static void xs_udp_data_receive(struct sock_xprt *transport)
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1330 {
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1331 struct sk_buff *skb;
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1332 struct sock *sk;
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1333 int err;
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1334
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1335 mutex_lock(&transport->recv_mutex);
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1336 sk = transport->inet;
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1337 if (sk == NULL)
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1338 goto out;
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1339 for (;;) {
7c13f97ffde63c Paolo Abeni 2016-11-04 @1340 skb = skb_recv_udp(sk, 0, 1, &err);
4f546149755b4d Trond Myklebust 2018-09-14 1341 if (skb == NULL)
4f546149755b4d Trond Myklebust 2018-09-14 1342 break;
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1343 xs_udp_data_read_skb(&transport->xprt, sk, skb);
850cbaddb52dfd Paolo Abeni 2016-10-21 1344 consume_skb(skb);
0af3442af7c4c5 Trond Myklebust 2018-01-14 1345 cond_resched();
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1346 }
0ffe86f48026b7 Trond Myklebust 2019-01-30 1347 xs_poll_check_readable(transport);
a246b0105bbd9a Chuck Lever 2005-08-11 1348 out:
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1349 mutex_unlock(&transport->recv_mutex);
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1350 }
f9b2ee714c5c94 Trond Myklebust 2015-10-06 1351
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists