netdev - Re: [PATCH net-next] net: remove noblock parameter from recvmsg() entities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 11 Apr 2022 03:59:18 +0800
From:   kernel test robot <lkp@...el.com>
To:     Oliver Hartkopp <socketcan@...tkopp.net>, netdev@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net
Cc:     kbuild-all@...ts.01.org, Oliver Hartkopp <socketcan@...tkopp.net>
Subject: Re: [PATCH net-next] net: remove noblock parameter from recvmsg()
 entities

Hi Oliver,

I love your patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Oliver-Hartkopp/net-remove-noblock-parameter-from-recvmsg-entities/20220411-025612
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 516a2f1f6f3ce1a87931579cc21de6e7e33440bd
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20220411/202204110353.gjbLL7o1-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/471dc1b8019d39c987dbdac34bb57678745739c8
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Oliver-Hartkopp/net-remove-noblock-parameter-from-recvmsg-entities/20220411-025612
        git checkout 471dc1b8019d39c987dbdac34bb57678745739c8
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/ethernet/chelsio/inline_crypto/chtls/ net/dccp/ net/sctp/ net/tls/ net/xfrm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_io.c: In function 'chtls_recvmsg':
>> drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_io.c:1753:65: warning: passing argument 5 of 'tcp_prot.recvmsg' makes pointer from integer without a cast [-Wint-conversion]
    1753 |                 return tcp_prot.recvmsg(sk, msg, len, nonblock, flags,
         |                                                                 ^~~~~
         |                                                                 |
         |                                                                 int
   drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_io.c:1753:65: note: expected 'int *' but argument is of type 'int'
   drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_io.c:1753:24: error: too many arguments to function 'tcp_prot.recvmsg'
    1753 |                 return tcp_prot.recvmsg(sk, msg, len, nonblock, flags,
         |                        ^~~~~~~~


vim +1753 drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_io.c

b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1738  
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1739  int chtls_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1740  		  int nonblock, int flags, int *addr_len)
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1741  {
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1742  	struct tcp_sock *tp = tcp_sk(sk);
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1743  	struct chtls_sock *csk;
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1744  	unsigned long avail;    /* amount of available data in current skb */
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1745  	int buffers_freed;
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1746  	int copied = 0;
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1747  	long timeo;
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1748  	int target;             /* Read at least this many bytes */
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1749  
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1750  	buffers_freed = 0;
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1751  
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31  1752  	if (unlikely(flags & MSG_OOB))
b647993fca1460 drivers/crypto/chelsio/chtls/chtls_io.c Atul Gupta 2018-03-31 @1753  		return tcp_prot.recvmsg(sk, msg, len, nonblock, flags,

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp